is there a more "groovy" way to write this gradle code?

[phil swenson]

if (project.hasProperty("profilingEnabled") && project.profilingEnabled) {
runAEJvmArguments << "-agentlib:yjpagent"
}

seems a bit verbose to me….

[Luke Daley]

Post by phil swenson
if (project.hasProperty("profilingEnabled") && project.profilingEnabled) {
runAEJvmArguments << "-agentlib:yjpagent"
}
seems a bit verbose to me….

if (project.properties.profilingEnabled) {
runAEJvmArguments << "-agentlib:yjpagent"
}

[phil swenson]

Dunno why I thought I needed "hasProperty"

But if I pass in -PprofilingEnabled=false, groovy would evaluate
project.profilingEnabled as true because the property is a string set
to "false"

In other words, in a conditional groovy evaluates "false" as true.

groovy> value = "false"
groovy> if (value){
groovy> println "true"
groovy> }
true

I think I need to do this:
if (project.properties.profilingEnabled == "true"){
runAEJvmArguments << "-agentlib:yjpagent"
}

Post by Luke Daley

Post by phil swenson
if (project.hasProperty("profilingEnabled") && project.profilingEnabled) {
       runAEJvmArguments << "-agentlib:yjpagent"
}
seems a bit verbose to me….

if (project.properties.profilingEnabled) {
      runAEJvmArguments << "-agentlib:yjpagent"
}
--
Luke Daley
Principal Engineer, Gradleware
http://gradleware.com
---------------------------------------------------------------------
   http://xircles.codehaus.org/manage_email

[Robert Fischer]

project.properties.profilingEnabled as Boolean

~~ Robert.

Post by phil swenson
Dunno why I thought I needed "hasProperty"
But if I pass in -PprofilingEnabled=false, groovy would evaluate
project.profilingEnabled as true because the property is a string set
to "false"
In other words, in a conditional groovy evaluates "false" as true.
groovy> value = "false"
groovy> if (value){
groovy>  println "true"
groovy> }
true
if (project.properties.profilingEnabled == "true"){
  runAEJvmArguments << "-agentlib:yjpagent"
}

Post by Luke Daley

Post by phil swenson
if (project.hasProperty("profilingEnabled") && project.profilingEnabled) {
       runAEJvmArguments << "-agentlib:yjpagent"
}
seems a bit verbose to me….

if (project.properties.profilingEnabled) {
      runAEJvmArguments << "-agentlib:yjpagent"
}
--
Luke Daley
Principal Engineer, Gradleware
http://gradleware.com
---------------------------------------------------------------------
   http://xircles.codehaus.org/manage_email

---------------------------------------------------------------------
   http://xircles.codehaus.org/manage_email

[Luke Daley]

Post by phil swenson
Dunno why I thought I needed "hasProperty"

Because doing project.profilingEnabled will throw an exception if that property hasn't been set. All of the example code uses hasProperty.

Post by phil swenson
But if I pass in -PprofilingEnabled=false, groovy would evaluate
project.profilingEnabled as true because the property is a string set
to "false"
In other words, in a conditional groovy evaluates "false" as true.
groovy> value = "false"
groovy> if (value){
groovy> println "true"
groovy> }
true
if (project.properties.profilingEnabled == "true"){
runAEJvmArguments << "-agentlib:yjpagent"
}

Correct, depending on how exact you need to be.

You could do:

if (Boolean.valueOf(project.properties.profilingEnabled)){
runAEJvmArguments << "-agentlib:yjpagent"
}

[Robert Fischer]

But project.properties.profilingEnabled doesn't throw an exception, right?

~~ Robert.

Post by Luke Daley

Post by phil swenson
Dunno why I thought I needed "hasProperty"

Because doing project.profilingEnabled will throw an exception if that property hasn't been set. All of the example code uses hasProperty.

Post by phil swenson
But if I pass in -PprofilingEnabled=false, groovy would evaluate
project.profilingEnabled as true because the property is a string set
to "false"
In other words, in a conditional groovy evaluates "false" as true.
groovy> value = "false"
groovy> if (value){
groovy>  println "true"
groovy> }
true
if (project.properties.profilingEnabled == "true"){
  runAEJvmArguments << "-agentlib:yjpagent"
}

Correct, depending on how exact you need to be.
if (Boolean.valueOf(project.properties.profilingEnabled)){
 runAEJvmArguments << "-agentlib:yjpagent"
}
--
Luke Daley
Principal Engineer, Gradleware
http://gradleware.com
---------------------------------------------------------------------
   http://xircles.codehaus.org/manage_email

[Luke Daley]

Post by Robert Fischer
But project.properties.profilingEnabled doesn't throw an exception, right?

Correct, it's using the standard Groovy feature of obtaining all of the project properties as a Map<String, ?>. We extend this in Gradle to be aware of all of the dynamic properties.